Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41593 )
Change subject: AGESA f14 boards: Drop useless family definitions ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41593/3/src/mainboard/amd/persimmon... File src/mainboard/amd/persimmon/buildOpts.c:
https://review.coreboot.org/c/coreboot/+/41593/3/src/mainboard/amd/persimmon... PS3, Line 31: #define BLDOPT_REMOVE_FAMILY_14_SUPPORT FALSE
Shouldn't this line be preserved? According to the instruction in a comment above...
That comment is just plain wrong. I've looked at AGESA and it does something completely different. Also, this commit does not change the resulting binary at all, so it's not breaking anything. I've made sure that all AGESA boards remain reproducible when doing these changes.
And yes, that comment needs to be dropped - done in the last commit