Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39422 )
Change subject: mb/google/dedede: Add ACPI configuration for USB ports ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39422/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39422/1/src/mainboard/google/dedede... PS1, Line 196: chip drivers/usb/acpi : register "desc" = ""USB2 Port Unused 1"" : register "type" = "UPC_TYPE_UNUSED" : device usb 2.5 on end : end : chip drivers/usb/acpi : register "desc" = ""USB2 Port Unused 2"" : register "type" = "UPC_TYPE_UNUSED" : device usb 2.6 on end : end : chip drivers/usb/acpi : register "desc" = ""USB2 Port Unused 3"" : register "type" = "UPC_TYPE_UNUSED" : device usb 2.7 on end : end Don't you just want to drop these? Or at least turn the devices off?
https://review.coreboot.org/c/coreboot/+/39422/1/src/mainboard/google/dedede... PS1, Line 235: chip drivers/usb/acpi : register "desc" = ""USB3 Port Unused 1"" : register "type" = "UPC_TYPE_UNUSED" : device usb 3.4 on end : end : chip drivers/usb/acpi : register "desc" = ""USB3 Port Unused 2"" : register "type" = "UPC_TYPE_UNUSED" : device usb 3.5 on end : end Same here?