Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43969 )
Change subject: smbios: Fix type 17 for Windows 10 ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/43969/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43969/3//COMMIT_MSG@21 PS3, Line 21: introduces introduce*d*
https://review.coreboot.org/c/coreboot/+/43969/3//COMMIT_MSG@25 PS3, Line 25: doesn't don't
https://review.coreboot.org/c/coreboot/+/43969/3//COMMIT_MSG@30 PS3, Line 30: any more anymore
https://review.coreboot.org/c/coreboot/+/43969/3/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/43969/3/src/arch/x86/smbios.c@1122 PS3, Line 1122: The later need to point to one type 16. : * Without those tables the physical installed system memory is guessed from : * system memory map, which is usually slightly less than memory present The type 17 tables need to point to a type 16 table. Otherwise, the physical installed memory size is guessed from the system memory map, which results in a slightly smaller value.