Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/44796 )
Change subject: gma baytrail: Add power and clocks support ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... File common/valleyview/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 69: return (Ref_Freq + Ref_Freq) / Int64 (Divider + 1);
I'll check if we have a div-round-closest somewhere (I think so) and put it to use here
Done
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 117: Config.Max_CDClk := 400_000_000;
This should match `CDClk` until switching is implemented.
Done, and left a comment stating CDClk switching isn't implemented yet
https://review.coreboot.org/c/libgfxinit/+/44796/3/common/valleyview/hw-gfx-... PS3, Line 121:
Nit, remove empty line.
Done