Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure ......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 1: if BOARD_SUPERMICRO_X11SSH_TF
_BASEBOARD_ missing
The used variant mechanism does not have a "baseboard" (it doesn't make sense when one doesn't know which board would be the "baseboard").
Think of it as if it was a board group: similar boards, which share a lot of common code, are grouped together to reuse said common code.
https://review.coreboot.org/c/coreboot/+/35426/16/src/mainboard/supermicro/x... PS16, Line 23: devicetree
overridetree. […]
Either overridetree.cb here, and make the relevant files proper overridetrees, or instead use: config DEVICETREE
The former would be preferred.