Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44250 )
Change subject: mb/google/volteer: add support for ddr4 memory
......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/44250/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/delbin/memory.c:
https://review.coreboot.org/c/coreboot/+/44250/1/src/mainboard/google/voltee...
PS1, Line 62: __weak
we don't want __weak on variants, do we? which one will the linker choose?
Good catch, only want that on the baseboard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4bca2bfa97530f0d04a0e8d90f01b8281d2aea6
Gerrit-Change-Number: 44250
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 06 Aug 2020 03:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment