build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32467 )
Change subject: soc/skl: set IGD resources only if its is enabled ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/romstage/romst... File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/romstage/romst... PS1, Line 313: * Set IGD stolen size to 64MB. The FBC hardware for skylake does not line over 80 characters
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/romstage/romst... PS1, Line 314: * have access to the bios_reserved range so it always assumes 8MB is line over 80 characters
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/romstage/romst... PS1, Line 315: * used and so the kernel will avoid the last 8MB of the stolen window. line over 80 characters
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/romstage/romst... PS1, Line 316: * With the default stolen size of 32MB(-8MB) there is not enough space line over 80 characters
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/systemagent.c File src/soc/intel/skylake/systemagent.c:
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/systemagent.c@... PS1, Line 60: if (!(config && config->ignore_vtd) && soc_is_vtd_capable()) that open brace { should be on the previous line
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/systemagent.c@... PS1, Line 63: sa_add_fixed_mmio_resources(dev, index, &soc_gfxvt_mmio_descriptor, 1); line over 80 characters
https://review.coreboot.org/#/c/32467/1/src/soc/intel/skylake/systemagent.c@... PS1, Line 64: sa_add_fixed_mmio_resources(dev, index, &soc_vtvc0_mmio_descriptor, 1); line over 80 characters