Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54959 )
Change subject: soc/intel/elkhartlake: Update FSP-S UPD LPSS related configs
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/54959/comment/f7579cb4_d0625cd9
PS6, Line 65: 0x1B44AC09;
Since you use constants here: Would you mind to add a comment which describes these values?
Done
https://review.coreboot.org/c/coreboot/+/54959/comment/8fa8ee59_c8f10c91
PS6, Line 102: params->SerialIoUartCtsPinMuxPolicy[0] = 0x2B01320F;
: params->SerialIoUartRtsPinMuxPolicy[0] = 0x2B01220E;
: params->SerialIoUartRxPinMuxPolicy[0] = 0x2B01020C;
: params->SerialIoUartTxPinMuxPolicy[0] = 0x2B01120D;
A comment describing the values would be nice here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c3cd1d37ff9892d09d6d86ac50e230549c7e53
Gerrit-Change-Number: 54959
Gerrit-PatchSet: 7
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 27 May 2021 07:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment