Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42496 )
Change subject: lib: Add ASan support to ramstage on x86 arch
......................................................................
Patch Set 26: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42496/26/src/include/asan.h
File src/include/asan.h:
https://review.coreboot.org/c/coreboot/+/42496/26/src/include/asan.h@42
PS26, Line 42:
Would you mind to align this comment properly with the line before?
https://review.coreboot.org/c/coreboot/+/42496/26/src/include/asan.h@45
PS26, Line 45:
Same here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica06bd2be78fcfc79fa888721ed920d4e8248f3b
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 26
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Tue, 11 Aug 2020 06:48:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment