Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32290 )
Change subject: Klocwork: Fix the Null pointer derefernce found by klocwork
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32290/6/src/soc/intel/broadwell/ramstage.c
File src/soc/intel/broadwell/ramstage.c:
https://review.coreboot.org/#/c/32290/6/src/soc/intel/broadwell/ramstage.c@3...
PS6, Line 34: assert(ps != NULL);
needs <assert.h>
https://review.coreboot.org/#/c/32290/6/util/cbfstool/cbfs_sections.c
File util/cbfstool/cbfs_sections.c:
https://review.coreboot.org/#/c/32290/6/util/cbfstool/cbfs_sections.c@70
PS6, Line 70: list_node pointer checked for NULL failed
nit: that's a little too low-level, maybe... how about "cannot allocate CBFS flag node"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32290
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15973ac28e9645826986cf63d2160eedb83024e4
Gerrit-Change-Number: 32290
Gerrit-PatchSet: 6
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Comment-Date: Fri, 12 Apr 2019 20:42:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment