Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45400 )
Change subject: soc/mediatek/mt8192: add pmic MT6315 driver ......................................................................
Patch Set 1:
(4 comments)
this seems largely duped with 6359P driver. Can we refactor them to share most of the code?
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/mt6315.h:
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/inc... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * : * This program is free software; you can redistribute it and/or modify : * it under the terms of the GNU General Public License as published by : * the Free Software Foundation; version 2 of the License. : * : * This program is distributed in the hope that it will be useful, : * but WITHOUT ANY WARRANTY; without even the implied warranty of : * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the : * GNU General Public License for more details. : */ SPDX
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/inc... PS1, Line 21: just one space.
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/inc... PS1, Line 34: #define MT6315_SWCID_H_CODE 0x15 : #define MT6315_SWCID_L_E1_CODE 0x10 : #define MT6315_SWCID_L_E2_CODE 0x20 : #define MT6315_SWCID_L_E3_CODE 0x30 enum
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/mt6... File src/soc/mediatek/mt8192/mt6315.c:
https://review.coreboot.org/c/coreboot/+/45400/1/src/soc/mediatek/mt8192/mt6... PS1, Line 17: #include <delay.h> SPDX