Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34882 )
Change subject: arch/x86: Move stack with CAR_GLOBAL_MIGRATION ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34882/1/src/include/stddef.h File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/34882/1/src/include/stddef.h@39 PS1, Line 39: #if defined(__PRE_RAM__) && CONFIG(ARCH_X86)
I did not realise it first, but I hit the AGESA -fno-zero-initialized-in-bss case with this approach […]
Can you elaborate on what is happening? Is it only affecting AGESA dependent compiles?
I think those values are getting put in .data which are also being allowed in that case. I think the reason is that .bss wasn't figured out correctly for libagesa. I very much don't want to do any of this workaround because of some broken AGESA handling. We should be binding the c flags to the objects that need them and not applying them globally to coreboot compilation units.