Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Ivy Jian, Jayvik Desai, Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/87301?usp=email )
Change subject: mb/google/nissa/var/dirks: correct usb2_ports setting
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/dirks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/87301/comment/0b6dc6c0_3d735ab0?usp... :
PS1, Line 74: USB2_A0
Add appropriate comments. e.g.
```suggestion
# This port is repurposed from Type-C to type-A port.
# Still declare it as Type-C port in order to set PortResetMessageEnable UPD.
register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC0)" # USB2_A0
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87301?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c4743d1d3bcf2567fdca9c0e07ed02c240d4baf
Gerrit-Change-Number: 87301
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 14 Apr 2025 07:08:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No