Attention is currently required from: Shelley Chen, Sumeet R Pawnikar.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81789?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Initialize NOTE_BOOK_MODE GPIO
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/81789/comment/bab00ed8_0a648265 :
PS5, Line 202: PAD_CFG_NF(GPP_E9, NONE, PLTRST, NF2),
Question: Should we have to use this always or should it be used only when ISH in full sensing mode?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81789?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a091b58deb855c7a7f1489a9506db2f821503b7
Gerrit-Change-Number: 81789
Gerrit-PatchSet: 5
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Wed, 10 Apr 2024 19:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment