Attention is currently required from: Nico Huber, Matt DeVillier, Angel Pons. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49056 )
Change subject: [TEST] abuild: Default to !CHROMEOS ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49056/comment/373bd4f7_e27f8259 PS4, Line 7: [TEST]
As long as nobody relies on the `default y` in newer mainboards, I would also […]
I mean, I think that generally the "feature Kconfigs" should always have the same defaults everywhere and there's no reason for any board to impose a different one from the rest. It's just a matter of consistency. CHROMEOS is one example but things like COLLECT_TIMESTAMPS, USE_OPTION_TABLE, BOOTSPLASH_IMAGE, TPM_MEASURED_BOOT, VBOOT, FATAL_ASSERTS, the various DEBUG_xxx configs... that's all stuff that is a fundamentally board-agnostic feature decision and no board should be overriding defaults for them. (Boards can use depends or select to constrain the value if it just doesn't work otherwise on that platform, but they shouldn't be overriding defaults.)
Maybe we can say that the general rule should be that mainboards and SoCs may only override defaults from options that cannot be changed in menuconfig? Or would that be too restrictive?