Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48627 )
Change subject: commonlib/region: Add null parameters handling ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48627/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48627/1//COMMIT_MSG@9 PS1, Line 9: Prevent NULL-pointer dereference of child or parent root_device parameter. I see you're adding multiple of these recently, but is there a particular reason for it in this case? I don't think we subscribe to the philosophy that every pointer argument ever should always be checked for NULL (that would just seem like pointless binary bloat). If it's a function where passing NULL seems like a likely mistake or there's a risk of it taking untrusted data adding checks would be fine, but with something simple and straight-forward like this I don't really see the point.