Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35023 )
Change subject: libpayload/usb: add USB 3.1 GEN2 support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35023/5/payloads/libpayload/drivers...
File payloads/libpayload/drivers/usb/usb.c:
https://review.coreboot.org/c/coreboot/+/35023/5/payloads/libpayload/drivers...
PS5, Line 702: * returns the speed is above SUPER_SPEED or not
Is an *if* missing?
returns if the speed is above …
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35023
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0ef12b2f0d91bf0d0db766bbc9019de1614a4f4
Gerrit-Change-Number: 35023
Gerrit-PatchSet: 5
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 13:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment