Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: google/kukui: Load calibration params and run DRAM calibration flow ......................................................................
Patch Set 19:
(13 comments)
https://review.coreboot.org/c/coreboot/+/35110/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35110/1//COMMIT_MSG@7 PS1, Line 7: full-k
What is full-k?
Commit message rephrased.
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 46: printk(BIOS_ERR, "dram.bin after _dram_init_code\n");
Please rephrase to be understandable to a user.
Done
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 74: printk(BIOS_INFO, "dram_blob load success\n");
Successfully loaded and run DRAM initialization blob.
Done
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 80: //load params from sdram-ddr-config
Please add a space after `//`.
Done
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 106: ASSERT(i == 0);
One tab too much?
Done
https://review.coreboot.org/c/coreboot/+/35110/1/src/mainboard/google/kukui/... PS1, Line 118: ASSERT(i == 0);
One tab too much?
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 41: if (ret == length) : return true; : else : return false;
return ret == length;
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 53: BIOS_ERR
BIOS_INFO?
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 53: %s with ret(0x%lx), length:0x%lx\n
%s: ret=%#lx, length=%#lx\n
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 55: if (ret == length) : return true; : else : return false;
return ret == length
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 73: BIOS_ERR
BIOS_INFO ?
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 75: if (ret == length) : return true; : else : return false;
return ret == length
Done
https://review.coreboot.org/c/coreboot/+/35110/10/src/mainboard/google/kukui... PS10, Line 144:
remove the extra blank line
Done