13 comments:
Patch Set #1, Line 7: full-k
What is full-k?
Commit message rephrased.
File src/mainboard/google/kukui/romstage.c:
Patch Set #1, Line 46: printk(BIOS_ERR, "dram.bin after _dram_init_code\n");
Please rephrase to be understandable to a user.
Done
Patch Set #1, Line 74: printk(BIOS_INFO, "dram_blob load success\n");
Successfully loaded and run DRAM initialization blob.
Done
Patch Set #1, Line 80: //load params from sdram-ddr-config
Please add a space after `//`.
Done
Patch Set #1, Line 106: ASSERT(i == 0);
One tab too much?
Done
Patch Set #1, Line 118: ASSERT(i == 0);
One tab too much?
Done
File src/mainboard/google/kukui/romstage.c:
if (ret == length)
return true;
else
return false;
return ret == length;
Done
Patch Set #10, Line 53: BIOS_ERR
BIOS_INFO?
Done
Patch Set #10, Line 53: %s with ret(0x%lx), length:0x%lx\n
%s: ret=%#lx, length=%#lx\n
Done
if (ret == length)
return true;
else
return false;
return ret == length
Done
Patch Set #10, Line 73: BIOS_ERR
BIOS_INFO ?
Done
if (ret == length)
return true;
else
return false;
return ret == length
Done
remove the extra blank line
Done
To view, visit change 35110. To unsubscribe, or for help writing mail filters, visit settings.