[coreboot-gerrit] Change in coreboot[master]: mainboard/google/octopus: Migrate onto SKU ID helpers

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39035 )

Change subject: mainboard/google/octopus: Migrate onto SKU ID helpers
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... 
File src/mainboard/google/octopus/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... 
PS11, Line 13: smm-y += mainboard_misc.c
> Yes, it is used to identify the SKUs which have LTE so that in those SKUs we can toggle few GPIOs to […]

Done

https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... 
File src/mainboard/google/octopus/mainboard_misc.c:

https://review.coreboot.org/c/coreboot/+/39035/11/src/mainboard/google/octop... 
PS11, Line 24: const char *smbios_system_sku(void)
> Nit: This function can be put back into mainboard.c and this file removed. […]

This is already handled in a follow up where we plan to collapse all these wrapping strong symbols down into a single strong symbol from src/ec/google/chromeec/ec_skuid.{o}.