Nico Huber has posted comments on this change. ( https://review.coreboot.org/23652 )
Change subject: src/cpu/intel: Don't hide pointers behind typedefs ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/23652/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23652/3//COMMIT_MSG@7 PS3, Line 7: src/cpu/intel: Don't hide pointers behind typedefs Please state what this patch does, not why. e.g.
cpu/intel: Use struct device
or
cpu/intel: Get rid off device_t
And remove the src/ prefix, that is obvious.
https://review.coreboot.org/#/c/23652/3//COMMIT_MSG@9 PS3, Line 9: See Change 7146 7146 has no commit message at all, so why point there??? You could state something like "Use of `device_t` has been abandoned in ramstage."
https://review.coreboot.org/#/c/23652/3/src/cpu/intel/haswell/smmrelocate.c File src/cpu/intel/haswell/smmrelocate.c:
https://review.coreboot.org/#/c/23652/3/src/cpu/intel/haswell/smmrelocate.c@... PS3, Line 312: dev = dev_find_slot(0, PCI_DEVFN(0, 0)); Why split in two lines?