[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/skyrim: override Markarth PCIe config

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74133 )

Change subject: mb/google/skyrim: override Markarth PCIe config
......................................................................

Patch Set 5:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74133/comment/b42cd26b_e1a7c8be 
PS3, Line 7: mb/google/skyrim
> Nah, that just makes the commit message longer without adding useful information. […]

I thought, it’s a common scheme, so it can easily be grepped for and parsed in `git log --oneline` output. But fine with me.

https://review.coreboot.org/c/coreboot/+/74133/comment/2a0e0d88_f924cb63 
PS3, Line 8:
> Because Markarth PCIe port 1 use for eMMc not SD.

As this is not a full sentence, I guess I thought something belonged before. Reading CB:73441 it is about boot time?

Also, referencing a source to check is always good. The schematics document the design, but of course there can be also errors in design and schematics. As the commit was documented only as build tested, for an outsider it would be good to know.

https://review.coreboot.org/c/coreboot/+/74133/comment/c0978174_7aafc631 
PS3, Line 17: TEST=emerge-skyrim coreboot chromeos-bootimage
> I've tested it on whiterun.  This mirrors what was done there. […]

Would be good to have this information in the commit message, and a reference to that change-set.