[coreboot-gerrit] [M] Change in coreboot[main]: vendorcode/amd: Hook up opensil

[Arthur Heymans (Code Review)]

Attention is currently required from: Felix Held, Martin L Roth, Martin Roth.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76511?usp=email )

Change subject: vendorcode/amd: Hook up opensil
......................................................................

Patch Set 13:

(1 comment)

File src/vendorcode/amd/opensil/genoa_poc/meson_cross.template:

https://review.coreboot.org/c/coreboot/+/76511/comment/696e72e9_9daae855 :
PS13, Line 18:           '-D_PORTING_H_=1',
> is this needed for opensil to build?

Yes. opensil uses asserts with values that can be evaluated at buildtime:
e.g.

if (something_that_should_not_happen)
    assert(false);

That won't work with coreboot's assert.