Attention is currently required from: Angel Pons.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support
......................................................................
Patch Set 25:
(3 comments)
Patchset:
PS25:
This looks very similar to the MBP10,1 port. […]
Well, I don't know, what about MBA4,2 then? Even more similar (in reality at least, while Pro is very different). They all are similar. MBP8,1 too.
File src/mainboard/apple/macbookair5_2/early_init.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/98167aee_ac271659
PS25, Line 33: }
The code for MBP10,1 dies if no SPD is found, I wonder why this is different here?
Forgot about it, will fix.
File src/mainboard/apple/macbookair5_2/gnvs.c:
PS23:
This file is a duplicate of acpi_tables.c […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32604
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ebe6f87a8254871698be74f913b9d969d722447
Gerrit-Change-Number: 32604
Gerrit-PatchSet: 25
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 21:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment