[coreboot-gerrit] Change in coreboot[master]: mb/intel/jasperlake_rvp: Add camera support Jasper Lake RVP

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39669 )

Change subject: mb/intel/jasperlake_rvp: Add camera support Jasper Lake RVP
......................................................................

Patch Set 17:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39669/17//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39669/17//COMMIT_MSG@7 
PS17, Line 7: mb/intel/jasperlake_rvp: Add camera support Jasper Lake RVP
nit: remove Jasper Lake RVP

https://review.coreboot.org/c/coreboot/+/39669/17//COMMIT_MSG@9 
PS17, Line 9: 1. Add support as per the schematics
Configure GPIOs as per schematics

https://review.coreboot.org/c/coreboot/+/39669/17/src/mainboard/intel/jasper... 
File src/mainboard/intel/jasperlake_rvp/Kconfig:

https://review.coreboot.org/c/coreboot/+/39669/17/src/mainboard/intel/jasper... 
PS17, Line 70: config VARIANT_HAS_CAMERA_ACPI
Since its by default y, shall we remove it and add ACPI file by default?