Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35163 )
Change subject: mb/supermicro: Add X10SLM+-LN4F as X10SLM variant
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35163/2/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x10slm/variants/x10slm-ln4f/devicetree.cb:
PS2:
I think using an overridetree, like the x220 and others do, would be optimal.
In my experience overridetrees haven't worked in the past, like values haven't changed or weren't even taken over.
@Christoph: If you decide for using it, please be aware of these issues and check the resulting configuration very carefully.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35163
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I686d8d4e2ec5b4eb2db214b6e0827ac9c33829d1
Gerrit-Change-Number: 35163
Gerrit-PatchSet: 2
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Comment-Date: Sun, 01 Sep 2019 20:12:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Gerrit-MessageType: comment