Attention is currently required from: Paul Menzel, Kyösti Mälkki, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42434 )
Change subject: cpu/x86/lapic: Only deliver ExtINT to BSP
......................................................................
Patch Set 13:
(1 comment)
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/42434/comment/a611cd6c_e831e2ab
PS5, Line 45: );
Do we install _any_ interrupt handlers in coreboot proper?
I don't think we do. Moreover, the `nmi` CMOS option is broken since the CMOS code clobbers the NMI enable bit. I know it doesn't disable all NMI sources, but controls many of them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78490d2cbe3d9f52e10ef2471508263fd6c146ba
Gerrit-Change-Number: 42434
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 15 Oct 2021 12:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment