[coreboot-gerrit] Change in coreboot[master]: mb/google/deltaur: add deltaur mainboard initial support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 )

Change subject: mb/google/deltaur: add deltaur mainboard initial support
......................................................................

Patch Set 14:

(2 comments)
> Patch Set 14:
> > Patch Set 14:
> >
> > Makefile.inc for variants/deltaur ?
>
> Nothing to add there right now so it is removed, baseboard is Makefile.inc is for Deltaur

I think deltaur and deltan are two variants that should have their own subdirectories. Even though the name deltaur is used for the baseboard, deltaur is its own variant.

https://review.coreboot.org/c/coreboot/+/39502/11/src/mainboard/google/delta... 
File src/mainboard/google/deltaur/Kconfig:

https://review.coreboot.org/c/coreboot/+/39502/11/src/mainboard/google/delta... 
PS11, Line 46: if !BOARD_GOOGLE_DELTAUR
> Removed overridetree.cb for deltaur, it shouldn't be there.

Why is that? I would think deltaur and deltan could have different devicetree settings that they would want to do. In general, I think each variant would want to have its own overridetree.

https://review.coreboot.org/c/coreboot/+/39502/14/src/mainboard/google/delta... 
File src/mainboard/google/deltaur/chromeos.c:

https://review.coreboot.org/c/coreboot/+/39502/14/src/mainboard/google/delta... 
PS14, Line 114: #if ENV_RAMSTAGE
if (ENV_RAMSTAGE)