Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32762 )
Change subject: soc/intel/broadwell: Don't use a pointer for pei_data ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32762/1/src/mainboard/intel/wtm2/romstage.c File src/mainboard/intel/wtm2/romstage.c:
https://review.coreboot.org/#/c/32762/1/src/mainboard/intel/wtm2/romstage.c@... PS1, Line 31: mainboard_fill_spd_data(&rp->pei_data); huh? copy-pasta
https://review.coreboot.org/#/c/32762/1/src/mainboard/purism/librem_bdw/roms... File src/mainboard/purism/librem_bdw/romstage.c:
https://review.coreboot.org/#/c/32762/1/src/mainboard/purism/librem_bdw/roms... PS1, Line 25: mainboard_fill_spd_data(&rp->pei_data); ...
https://review.coreboot.org/#/c/32762/1/src/soc/intel/broadwell/include/soc/... File src/soc/intel/broadwell/include/soc/romstage.h:
https://review.coreboot.org/#/c/32762/1/src/soc/intel/broadwell/include/soc/... PS1, Line 21: #include <soc/pm.h> hmm, why?
https://review.coreboot.org/#/c/32762/1/src/soc/intel/broadwell/include/soc/... PS1, Line 25: struct pei_data; drop