Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31707 )
Change subject: cbfstool: Support new FMD flag "PRESERVE"
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31707/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31707/3//COMMIT_MSG@16
PS3, Line 16: that FMAP generator will set
: right area_flag value
I do not fully understand this part. Can you rephrase?
… that the FMAP generator will use as the area_flag value?
https://review.coreboot.org/#/c/31707/3//COMMIT_MSG@20
PS3, Line 20: an x86 image
Please be specific and note, which one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51e7d31029b98868a1cab0d26bf04a14db01b1c0
Gerrit-Change-Number: 31707
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 11:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment