Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39340 )
Change subject: chromeos: remove get_write_protect_state function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39340/3/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/39340/3/src/drivers/mrc_cache/mrc_c... PS3, Line 438: /* Read Write Protect GPIO if available */ : wp_gpio = get_write_protect_state();
One problem that I can think of here is: when SW WP is enabled, but HW WP isn't. […]
Hmmm... +Hung-Te for updater expertise. Are we ever really overwriting the MRC cache regions anyway? They seem to be marked as PRESERVE in the FMAPs, so I think the updater should copy the old data into the new image before flashing, and then flashrom should detect that they're unchanged and never really issue a write command to the SPI controller.
I definitely think it would be worth finding some sort of solution for this so we don't have to carry around this one extra piece of coupling in every single board.