Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40207 )
Change subject: Replace DEVICE_NOOP with noop_(set|read)_resources ......................................................................
Patch Set 1:
I believe that using uppercase macros would highlight the special status of these ops
But why highlight a special status that we don't understand? I know I probably should just push a patch that removes the whole topic (error printing for these particular two function pointers). But I know it's even less likely to find somebody who would feel confident enough to give a +2. Hence, taking baby steps here.
Yes, I am less keen on this change because that is precisely why I used an uppercased macro.
Ack. Please clear this up for us, why should these no-op pointers stick out? And what is the intended effect when they stick out?
In my experience, people see such MACRO_NAMES as boilerplate, something to copy-paste without thinking.
It is very easy and obvious to parse by eye or grep for, you certainly can't miss it.
Yes, obviously. But missing that there _is_ a no-op pointer is not a problem. Problems arise when we miss to set any pointer at all, and that is hard to see. Absence of upper-case looks the same as absence of lower case.
What are we actually fixing here, just style?
See commit message.