[coreboot-gerrit] Patch set updated for coreboot: i82801gx: Enable PCI-to-PCI bridge

[Kyösti Mälkki]

Kyösti Mälkki ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/2706

-gerrit

commit 3574c5cc446992ab9ab67a90a6c2ab141c663297
Author: Kyösti Mälkki 
Date:   Wed Mar 13 11:12:56 2013 +0200

i82801gx: Enable PCI-to-PCI bridge

Once the PCI command register is written the bridge forwards
    future IO and memory regions, as programmed in the respective base
    and limit registers, to the secondary PCI bus.

Since the LPC function claims the resources for IOAPIC, ROM and
    low IO (0x0-0xfff) in its read_resources() call, the PCI-to-PCI
    configuration will not overlap those regions and does not hide
    the resources mentioned in the original comment.

The bridge was disable in the following commit [1]

commit a8e1168064b34b46494b58480411a11bc98340f6
        Author: Stefan Reinauer 
        Date:   Wed Mar 11 14:54:18 2009 +0000

This patch contains some significant updates to the i82801gx component and will
            be required for a series of later patches. Roughly it contains:

but unfortunately it was not noted which system this caused
    problems with.

[1] http://review.coreboot.org/gitweb?p=coreboot.git;a=commit;h=a8e1168064b34b46...

Change-Id: I75128d83a344f4a0e09a3ea623c7f92a016ebfb9
    Signed-off-by: Kyösti Mälkki 
---
 src/southbridge/intel/i82801gx/pci.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/southbridge/intel/i82801gx/pci.c b/src/southbridge/intel/i82801gx/pci.c
index afc275a..1171491 100644
--- a/src/southbridge/intel/i82801gx/pci.c
+++ b/src/southbridge/intel/i82801gx/pci.c
@@ -58,7 +58,6 @@ static void pci_init(struct device *dev)
    pci_write_config16(dev, SECSTS, reg16);
 }

-#undef PCI_BRIDGE_UPDATE_COMMAND
 static void ich_pci_dev_enable_resources(struct device *dev)
 {
    const struct pci_operations *ops;
@@ -76,16 +75,8 @@ static void ich_pci_dev_enable_resources(struct device *dev)

command = pci_read_config16(dev, PCI_COMMAND);
    command |= dev->command;
-#ifdef PCI_BRIDGE_UPDATE_COMMAND
-	/* If we write to PCI_COMMAND, on some systems
-	 * this will cause the ROM and APICs not being visible
-	 * anymore.
-	 */
    printk(BIOS_DEBUG, "%s cmd <- %02x\n", dev_path(dev), command);
    pci_write_config16(dev, PCI_COMMAND, command);
-#else
-	printk(BIOS_DEBUG, "%s cmd <- %02x (NOT WRITTEN!)\n", dev_path(dev), command);
-#endif
 }

static void ich_pci_bus_enable_resources(struct device *dev)