Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38989 )
Change subject: Kconfig,Makefile.inc: Add support for link time optimization ......................................................................
Patch Set 8:
(5 comments)
https://review.coreboot.org/c/coreboot/+/38989/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38989/2//COMMIT_MSG@23 PS2, Line 23: the Thinkpad T500, and both targets boot successfully.
For the T500 it's ~8ms less, but otherwise about the same. […]
Done
https://review.coreboot.org/c/coreboot/+/38989/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38989/3//COMMIT_MSG@14 PS3, Line 14: - The dead_code() macro causes linking errors, since dead functions
I recall having some problems with it early on, but I can't reproduce them anymore. […]
Done
https://review.coreboot.org/c/coreboot/+/38989/2/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/38989/2/src/Kconfig@123 PS2, Line 123: depends on COMPILER_GCC
I am able to successfully build and boot QEMU i440fx with LLVM/Clang.
Done
https://review.coreboot.org/c/coreboot/+/38989/4/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/38989/4/src/Kconfig@120 PS4, Line 120: bool "Use link time optimization"
Also add *(LTO)* at the end.
Done
https://review.coreboot.org/c/coreboot/+/38989/4/src/Kconfig@122 PS4, Line 122: default y
Could you split `default y` out to a separate commit please on top. […]
Done