Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48608 )
Change subject: mb/google/kahlee: move SMI/SCI GPIO setup to ramstage
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48608/3/src/mainboard/google/kahlee...
File src/mainboard/google/kahlee/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/48608/3/src/mainboard/google/kahlee...
PS3, Line 19: PAD_GPI
I know this change is already submitted. […]
since I don't have a google/kahlee variant to test this on, i just went the safe route here. if you can verify that removing those 3 GPIs in here doesn't have any negative impact, I'd like you to push a patch that removes them
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I733bb91ef60dc66093781a376a2e9837f5209671
Gerrit-Change-Number: 48608
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 16 Dec 2020 18:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment