Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37620 )
Change subject: soc/intel/cannonlake: Make Heci configurable
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37620/2/src/soc/intel/cannonlake/fs...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37620/2/src/soc/intel/cannonlake/fs...
PS2, Line 371: #if !CONFIG(HECI_DISABLE_USING_SMM)
: params->Heci1Disabled = !config->HeciEnabled;
: #endif
Convert that to C if?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa5b1440b4d6622cef0bfe82dc22a81b55f12bda
Gerrit-Change-Number: 37620
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 10:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment