Attention is currently required from: Angel Pons, Benjamin Doron, Felix Held, Felix Singer, Martin Roth, Maximilian Brune, Patrick Rudolph.
Nicholas Chin has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86772?usp=email )
Change subject: doc/arch/x86: Add MP-Init documentation ......................................................................
Patch Set 5:
(6 comments)
File Documentation/arch/x86/mp_init.md:
PS5: Please reflow lines to about 72 characters: https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
https://review.coreboot.org/c/coreboot/+/86772/comment/58a07d16_6eaadc4c?usp... : PS5, Line 31: init_bsp() Enclose function name in backticks so that it renders as an inline code block ```suggestion First `init_bsp()` initializes the bootstrap processor. After this we are ready to initialize all other logical processors (the APs). On a hyperthreading CPU that means all physical threads. We need initialize all APs from scratch. Among other we need setup a stack, GDT, IDT, caching and a fewer other things. Since we need to setup a stack, we need to start in assembly for all APs. That is what the `src/cpu/x86/sipi_vector.S` is for. ```
https://review.coreboot.org/c/coreboot/+/86772/comment/ac977440_38fc02eb?usp... : PS5, Line 36: ap_init() Same here ```suggestion The assembly code will do the bare minimum initialization before eventually jumping to c-code. That c-code is usually the `ap_init()` function. But first we need to tell the APs to wake up and start executing the SIPI vector code. We can use the "Interrupt Command Register" to issue interrupts to other local APICs (and therefore other logical processors) causing them to wake up and execute from an address of our choice (with certain restrictions). ```
https://review.coreboot.org/c/coreboot/+/86772/comment/6e0e524a_740fd0e7?usp... : PS5, Line 56: setting Capitalize ```suggestion ### Setting up SMM ```
https://review.coreboot.org/c/coreboot/+/86772/comment/1e3ebf55_1af599ff?usp... : PS5, Line 58: implemented in SMM. : Now Markdown requires a blank line in between paragraphs, otherwise it renders as the same paragraph.
https://review.coreboot.org/c/coreboot/+/86772/comment/a5c8afa6_97f2a2b2?usp... : PS5, Line 59: jumps. : Unf Same here, add a blank line