Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42503 )
Change subject: post_code: replace postcode values with their respective defined constants
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42503/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42503/11//COMMIT_MSG@9
PS11, Line 9: Replace existing post_code call values with their defined constants
If this is only about replacing hex numbers with equivalent macros (same value), it should be reprod […]
Forget about reproducibility... I see that most postcode values are changed...
In that case, it would make more sense to define and use postcodes in the same commit, a few postcodes (e.g. postcodes for a single stage) at a time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32f43104a829bd1db0d5f5340cc94bf0c717c39
Gerrit-Change-Number: 42503
Gerrit-PatchSet: 11
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 09 Jul 2020 12:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment