Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )
Change subject: mb/google/hatch: Create palkia variant ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/memory.c:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 87: /* : * For boards with id 0 or unknown, memory straps 3 and 4 are : * incorrectly stuffed in hardware. This is a workaround for these : * boards to override memory strap 3 to 0 and 4 to 1. : */
Yes , Palkia use the same memory config table as Helios . It should be suitable as Palkia .
Ack
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 11: [PchSerialIoIndexI2C5] = PchSerialIoPci,
Should be disabled
Done
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 13: [PchSerialIoIndexSPI1] = PchSerialIoPci,
I think this should be disabled as well
Done
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 30: GSPI1
GSPI0 ?
Ack
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 53: .i2c[3] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 150, : .fall_time_ns = 150, : }, On CB:33384 (same change as your link), Furquan said:
You don't need a value for the unused buses.
Therefore, I believe this value is not necessary for Palkia.
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 27: Kohaku
But this is not Kohaku?
Ack