Attention is currently required from: Philipp Hug, Patrick Georgi, Jakub Czapiga, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64737 )
Change subject: commonlib: Clean up compiler.h ......................................................................
Patch Set 4:
(8 comments)
File src/commonlib/bsd/include/commonlib/bsd/compiler.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/35e8f73e_b8781e8b PS4, Line 8: #define __packed __attribute__((__gcc_struct__, __packed__)) Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/702b2f35_b172a2aa PS4, Line 10: #define __packed __attribute__((__packed__)) Prefer __packed over __attribute__((__packed__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/92852789_a846fcbf PS4, Line 15: #define __aligned(x) __attribute__((__aligned__(x))) Prefer __aligned(x) over __attribute__((__aligned__(x)))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/ae1c1fd1_9107a955 PS4, Line 19: #define __unused __attribute__((__unused__)) __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/4fb0ec37_91917fad PS4, Line 27: #define __weak __attribute__((__weak__)) Prefer __weak over __attribute__((__weak__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/538a4768_f9c6d63b PS4, Line 31: #define __noreturn __attribute__((__noreturn__)) Prefer __noreturn over __attribute__((__noreturn__))
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/9ce4fb90_1bddc896 PS4, Line 35: #define __always_inline inline __attribute__((__always_inline__)) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150416): https://review.coreboot.org/c/coreboot/+/64737/comment/09270676_6ec266b1 PS4, Line 35: #define __always_inline inline __attribute__((__always_inline__)) Prefer __always_inline over __attribute__((__always_inline__))