Attention is currently required from: Jérémy Compostella, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79834?usp=email )
Change subject: arch/x86/include/smm_call: improve documentation of call_smm
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79834/comment/8747eb39_56274b9b :
PS2, Line 9: Since the inline assembly code doesn't make it exactly obvious how this
This sentence is a bit confusing in IMO.
removed the part of the sentence that might make this less clear; also that information is added as comment on the function, so no need to also have that in the commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79834?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3566af191492ce00a3033335ff80e01c33e98e63
Gerrit-Change-Number: 79834
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Comment-Date: Wed, 10 Jan 2024 14:56:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment