Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30939 )
Change subject: nb/intel/pineview: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/30939/4/src/mainboard/intel/d510mo/early_ini...
File src/mainboard/intel/d510mo/early_init.c:
https://review.coreboot.org/#/c/30939/4/src/mainboard/intel/d510mo/early_ini...
PS4, Line 36: | COMB_LPC_EN);
whitespace?
https://review.coreboot.org/#/c/30939/4/src/mainboard/intel/d510mo/early_ini...
PS4, Line 43:
whitespace?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e74838b0d5e9c192082084cfd9821996f0e4c50
Gerrit-Change-Number: 30939
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 13 Apr 2019 06:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment