[coreboot-gerrit] Change in coreboot[master]: util/superiotool: Drop one SCH5317 entry

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39376 )

Change subject: util/superiotool: Drop one SCH5317 entry
......................................................................

Patch Set 1:
> Patch Set 1: Code-Review+2
>
> No strong feelings about this. But it's just working around a bigger
> issue: Probing a single byte is not a good idea. We are hit by the
> 0x85 entry because IT85xx chips are popular atm. But all the other
> entries can give false positives, too. IMHO, the probing function
> should be adapted, maybe even hidden behind a command line switch.
>
> It's not the first workaround btw., somebody already started to
> filter false-positives in probe_idregs_smsc_helper().

I see. However, the FDC37N972 has a register dump, so it was a good idea to keep it. However, as there's no datasheet for the SCH5317, checking more bytes is not really feasible to do.

Let's not forget that the IT8502E exists as well, which would be detected as a SCH5317 with revision 0x02...