Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41614 )
Change subject: mb/google/volteer/var/ripto: Use auto-generated Makefile.inc using gen_part_id.go
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41614/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/ripto/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41614/8/src/mainboard/google/voltee...
PS8, Line 1: ## SPDX-License-Identifier: GPL-2.0-or-later
We should probably note this file is generated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb06443a5c7fd80915f66b806cdd7c3ae1275b05
Gerrit-Change-Number: 41614
Gerrit-PatchSet: 8
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 04:23:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment