Nico Huber has posted comments on this change. ( https://review.coreboot.org/19695 )
Change subject: ec/lenovo/h8: Add panic method
......................................................................
Patch Set 11:
There haven't been any additional comments in a week, so I'm going
to merge this as it is.
What else would there have to be to comment? The default is a PITA
for developers and non-devs will hardly ever notice it.
It's easy enough to change if people find
that the default is too annoying.
Ofc it is. But developers don't want to set every option to there
personal preference every time they are asked to just test something.
If any ThinkPad ever screams at me at night because of this default,
I'll probably stop testing on them.
--
To view, visit
https://review.coreboot.org/19695
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id34d399f154952a48c1f4ccb0c41a238b2d7ccb8
Gerrit-Change-Number: 19695
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 21 Aug 2017 17:03:14 +0000
Gerrit-HasComments: No