Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74620 )
Change subject: soc/intel/common: add power limits update support for variants
......................................................................
Patch Set 3:
(4 comments)
File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/74620/comment/b280f2de_bce919bf
PS2, Line 47: u8
nit: uint8_t
Ack
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/74620/comment/26a6b612_7c53ba34
PS2, Line 12:
: #include <drivers/intel/dptf/chip.h>
order please?
Ack
https://review.coreboot.org/c/coreboot/+/74620/comment/0b6a332b_b8d38184
PS2, Line 249: mchid
nit: mch_id?
Done
https://review.coreboot.org/c/coreboot/+/74620/comment/34aba9bd_82da9439
PS2, Line 251: u8
uint8_t
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I414715f211d816bbfad03a673ca96dd5df94caeb
Gerrit-Change-Number: 74620
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 03 May 2023 11:43:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment