Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31318 )
Change subject: soc/amd/common: Move PI refcode loader
......................................................................
Patch Set 3:
I understand there were some iterations how binaryPI blobs are constructed. Could you go through the Kconfig variables and this file for deprecated and obsolete parts.
Also, instead of new file refcode_loader.c maybe move the code to image.c instead. At the time I originally did this change locally, image.c did not exist.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68885e7f855b195c178e746c8f3f0f49166d0def
Gerrit-Change-Number: 31318
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 11 Feb 2019 05:05:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment