Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Patrick Rudolph, Felix Held.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62362 )
Change subject: treewide: Drop unused Kconfig symbols
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/62362/comment/377a4d3b_c892edc4
PS2, Line 104:
: config INTEL_GMA_OPREGION_2_0
: bool
: default n if INTEL_GMA_OPREGION_2_1
: default y
Sure, but look at the way these two Kconfigs are structured; OPREGION_2_0 is the default, unless INT […]
what I see is "INTEL_GMA_OPREGION_2_1" set to no by default here :
src/drivers/intel/gma/Kconfig:
"config INTEL_GMA_OPREGION_2_1
bool
default n"
meaning the function
static struct opregion_version opregion_get_version(void)
{
if (CONFIG(INTEL_GMA_OPREGION_2_1))
return (struct opregion_version) { .major = 2, .minor = 1 };
return (struct opregion_version) { .major = 2, .minor = 0 };
}
returns "(struct opregion_version) { .major = 2, .minor = 0 }" unless INTEL_GMA_OPREGION_2_1 is selected
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96380d4567356c81e17de469fd78cec2fcb7e5c9
Gerrit-Change-Number: 62362
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 06 Mar 2022 10:45:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment