YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31626 )
Change subject: google_chromeec_command: makes the error status consistent
......................................................................
Patch Set 1:
(1 comment)
Thanks for the comments. Keeping the check as they are while returning "-1" seems to be acceptable by all it seems?
https://review.coreboot.org/#/c/31626/1/src/ec/google/chromeec/ec.h
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/#/c/31626/1/src/ec/google/chromeec/ec.h@164
PS1, Line 164: @return 0 on success or negative integer for errors.
Currently, != 0 works and it's consistent. […]
Yes, the caller can definitely use "!= 0" which still conforms to this comment. But the comment itself needs to be accurate or else it would be misleading?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31626
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39f12502bc6982670dd200dcef0724e7eed2ed29
Gerrit-Change-Number: 31626
Gerrit-PatchSet: 1
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 27 Feb 2019 18:23:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-MessageType: comment