Thanks for the comments. Keeping the check as they are while returning "-1" seems to be acceptable by all it seems?

View Change

1 comment:

• File src/ec/google/chromeec/ec.h:

  • Patch Set #1, Line 164: @return 0 on success or negative integer for errors.

    Currently, != 0 works and it's consistent. […]

    Yes, the caller can definitely use "!= 0" which still conforms to this comment. But the comment itself needs to be accurate or else it would be misleading?

To view, visit change 31626. To unsubscribe, or for help writing mail filters, visit settings.